long5hot added inline comments.
Comment at: clang/test/Driver/ppc-abi.c:18
// RUN: -mabi=altivec | FileCheck -check-prefix=CHECK-ELFv2 %s
+// RUN: %clang --target=ppc64 -mabi=elfv1 %s -### -o %t.o 2>&1 \
+// RUN: | FileCheck -check-prefix=CHECK-UNKNOWN-ELFv1 %s
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG065da3574b4f: clang driver throws error for -mabi=elfv2 or
elfv2 (authored by long5hot).
Changed prior to commit:
MaskRay added inline comments.
Comment at: clang/test/Driver/ppc-abi.c:18
// RUN: -mabi=altivec | FileCheck -check-prefix=CHECK-ELFv2 %s
+// RUN: %clang -target powerpc64le-unknown-unknown-gnu %s -### -o %t.o 2>&1 \
+// RUN: -mabi=elfv1 | FileCheck
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
Ah, ok. This makes sense. When we don't know anything about the ABI, it makes
sense to rely on `-mabi`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
long5hot updated this revision to Diff 544674.
long5hot added a comment.
Herald added a subscriber: kbarton.
failure is only when we do not give full target triple.
for e.x. --target=ppc64 -mabi=elfv2
or even when OS option is unknown e.g. --target=powerpc64-unknown-gnu
Repository:
rG LLVM
MaskRay added a comment.
> After clang release/16.x there is a regression that -mabi=elfv1 or
> -mabi=elfv2 are being unused and throws warning.
Please just give the full clang command line and add a test case under
`test/Driver`. FWIW: `clang --target=powerpc64le-linux-gnu -mabi=elfv1
long5hot created this revision.
Herald added a project: All.
long5hot requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
After clang release/16.x there is a regression that -mabi=elfv1
or -mabi=elfv2 are being unused and throws
