[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3970-4009 if (Left.is(tok::l_paren) || Right.is(tok::r_paren)) { if (Right.is(TT_CastRParen) || (Left.MatchingParen && Left.MatchingParen->is(TT_CastRParen))) { return

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare updated this revision to Diff 558066. gedare added a comment. Rebase to D155529 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360 Files:

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16786 verifyFormat("SomeType *__attribute__( ( attr ) ) *a = NULL;", Spaces); - verifyFormat("void __attribute__( ( naked ) ) foo( int bar )", Spaces); + verifyFormat("void __attribute__( ( x )

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16786 verifyFormat("SomeType *__attribute__( ( attr ) ) *a = NULL;", Spaces); - verifyFormat("void __attribute__( ( naked ) ) foo( int bar )", Spaces); + verifyFormat("void

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare updated this revision to Diff 544544. gedare added a comment. Add tests and correct function call detection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360 Files:

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

HazardyKnusperkeks added a comment. You need some tests to show that the new options really apply like intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. This change separates function calls, declarations,