[PATCH] D156441: [clangd]Fix addUsing tweak doesn't traverse same-level anon namespaces

2023-08-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This would be a great fix to have! However I don't think the specific changes to the RecursiveASTVisitor are correct. I can see a couple of approaches: 1. prevent the RecursiveASTVisitor from traversing into uninteresting contexts, and drop the Encloses check in

[PATCH] D156441: [clangd]Fix addUsing tweak doesn't traverse same-level anon namespaces

2023-08-02 Thread zhou via Phabricator via cfe-commits
chouzz added a comment. @kadircet Could you please take a look this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156441/new/ https://reviews.llvm.org/D156441 ___ cfe-commits mailing list

[PATCH] D156441: [clangd]Fix addUsing tweak doesn't traverse same-level anon namespaces

2023-07-27 Thread zhou via Phabricator via cfe-commits
chouzz created this revision. chouzz added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. chouzz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This