This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d494e76d098: [Clang] Handle static_assert messages with an
expression started by a literal (authored by cor3ntin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
cor3ntin updated this revision to Diff 545627.
cor3ntin added a comment.
Typo + format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156597/new/
https://reviews.llvm.org/D156597
Files:
clang/lib/Parse/ParseDeclCXX.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from minor nits.
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1022
+ for(unsigned I = 0; ; ++I) {
+const Token & T =
cor3ntin added inline comments.
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1019
-if (isTokenStringLiteral())
- AssertMessage = ParseUnevaluatedStringLiteralExpression();
-else if (getLangOpts().CPlusPlus26)
+bool ParseAsExression = false;
+
tbaeder added inline comments.
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1019
-if (isTokenStringLiteral())
- AssertMessage = ParseUnevaluatedStringLiteralExpression();
-else if (getLangOpts().CPlusPlus26)
+bool ParseAsExression = false;
+
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D156597
Files:
clang/lib/Parse/ParseDeclCXX.cpp
