This revision was automatically updated to reflect the committed changes.
Closed by commit rG11b7ce26f2a2: [ASanStableABI][Driver] Stop linking to asan
dylib when stable abi is enabled (authored by Blue Gaston
bgast...@apple.com).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
wrotki accepted this revision.
wrotki added a comment.
Yes, it looks good. I downloaded the patch and ran the test - had some doubts
about 'otool -L %t |grep -q "dynamic.dylib"' - but verified with other ASAN
tests binaries and convinced myself that it's the right thing to do.
CHANGES SINCE
rsundahl accepted this revision.
rsundahl added a comment.
This revision is now accepted and ready to land.
This looks good to me. Thanks for the additional clean-up @thetruestblue.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156718/new/
https://reviews.llvm.org/D156718
thetruestblue updated this revision to Diff 546199.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156718/new/
https://reviews.llvm.org/D156718
Files:
clang/include/clang/Driver/SanitizerArgs.h
clang/lib/Driver/ToolChains/Darwin.cpp
compiler-rt/test/asan_abi/CMakeLists.txt
thetruestblue created this revision.
thetruestblue added reviewers: yln, rsundahl, usama54321, wrotki, kubamracek,
vitalybuka, MaskRay.
Herald added a subscriber: Enna1.
Herald added a project: All.
thetruestblue requested review of this revision.
Herald added projects: clang, Sanitizers.
Herald
