[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3edd338a6407: [clang-repl] Add Documentation for Execution Results Handling. (authored by Krishna-13-cyber, committed by v.g.vassilev). Repository:

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev accepted this revision. v.g.vassilev added a comment. The pre-merge check seems to fail at clang-format for some reason. This patch does not change anything that should be formatted by clang-format. We will try to add the images as editable graphviz content. We need to see if the

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks @Krishna-13-cyber for the prompt efforts @v.g.vassilev it is ready to commit as far as I can see Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 549745. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher added a comment. @Krishna-13-cyber added Graphviz code snippets to replace all .png images Comment at: clang/docs/ClangRepl.rst:248-250 +.. image:: valuesynth.png + :align: center + :alt: valuesynth design v.g.vassilev wrote: > Can we replace

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/ClangRepl.rst:221 + +Execution Results Handling features discussed below help extend the Clang-REPL +functionality by creating an interface between the execution results of a We should probably spell

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher added inline comments. Comment at: clang/docs/ClangRepl.rst:393-396 + +.. image:: autoprint.png + :align: center + :alt: autoprint design Please replace the image reference with the following Graphviz code (do not delete the image .png for now,

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. Added minor changes requested by Vassil Comment at: clang/docs/ClangRepl.rst:296 + +For example, the CPPYY code makes use of this feature to enable

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. accepting current revision, one minor change is still required, adding that separately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 549034. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. added minor changes based on Vassil's review during docs meeting Comment at: clang/docs/ClangRepl.rst:220-230 + +:doc:`ExecutionResultsHandling` helps

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/ExecutionResultsHandling.rst:80 + +For example, the CPPYY code makes use of this feature to enable running +C++ within Python. It enables transporting values/information between C++ cppyy seems

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks @Krishna-13-cyber for the prompt changes. @v.g.vassilev If no further changes are required by @junaire , then this should be ready to merge Repository: rG LLVM Github

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547574. Krishna-13-cyber added a comment. - Update section of Execution Results Handling in Clang-REPL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547529. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. Thanks @junaire for the clarification, following is the updated document structure: 1. Capture Execution Results - How the Feature works - more details -

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

junaire added a comment. I want to clarify: We offer two features: 1. capture the execution results and bring it back to the compiled program. 2. dump the captured value (value printing/automatic printf) and all the parsing, ast transform and balabala, these are all implementation details. The

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks for the updates, look OK to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547231. Krishna-13-cyber added a comment. - Addressed the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/index.rst:96 ClangRepl + ExecutionResultsHandling We should probably move that under `ClangRepl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. added some comments for minor changes. Two sections to be removed since they are not yet merged to upstream code: - Complex Data Types - Users can create their own types

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: v.g.vassilev, davidlange6, QuillPusher. Herald added a subscriber: arphaman. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: