[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-11 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa563ced78bb4: [clang-tidy] Implement cppcoreguidelines CP.52 (authored by ccotter, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-10 Thread Chris Cotter via Phabricator via cfe-commits
ccotter marked an inline comment as done. ccotter added a comment. @PiotrZSL would you mind landing this for me? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-06 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 547585. ccotter added a comment. - Use matchesAnyListedName and fix windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-06 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:27 + namesType(templateSpecializationType(hasDeclaration(namedDecl( + hasAnyName(utils::options::parseStringList(LockGuards))); +

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 547573. ccotter marked 5 inline comments as done. ccotter added a comment. - Add tests, do not inspect instantiations, add option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-05 Thread Chris Cotter via Phabricator via cfe-commits
ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:24-26 + hasType(recordDecl(hasAnyName( + "::std::unique_lock", "::std::lock_guard", +

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-04 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Consider ignoring template instances, to avoid generating lot of warnings for each instance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-04 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:24-26 + hasType(recordDecl(hasAnyName( + "::std::unique_lock", "::std::lock_guard", +

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-03 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 +- New :doc:`cppcoreguidelines-no-suspend-with-lock + ` check. Please keep alphabetical order in new checks list. Comment at:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-03 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 547061. ccotter added a comment. - Specify version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

2023-08-03 Thread Chris Cotter via Phabricator via cfe-commits
ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: