[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

2023-08-05 Thread Tyler Lanphear via Phabricator via cfe-commits
tylanphear added a comment. In D157078#4563212 , @RKSimon wrote: > In D157078#4562788 , @tylanphear > wrote: > >> Seeing the link error downstream. I think clangSerialization needs to be >> added to the link lib

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

2023-08-05 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. In D157078#4562788 , @tylanphear wrote: > Seeing the link error downstream. I think clangSerialization needs to be > added to the link libraries. Should be fixed by 36daf3532d91bb

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

2023-08-04 Thread Tyler Lanphear via Phabricator via cfe-commits
tylanphear added a comment. Seeing the link error downstream. I think clangSerialization needs to be added to the link libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157078/new/ https://reviews.llvm.org/D157078 _

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

2023-08-04 Thread Lei Huang via Phabricator via cfe-commits
lei added a comment. This is causing a ld.lld link failure in https://lab.llvm.org/buildbot/#/builders/57 FAILED: tools/clang/tools/extra/include-cleaner/unittests/ClangIncludeCleanerTests : && /home/buildbots/clang.15.0.4/bin/clang++ --gcc-toolchain=/usr -fPIC -fno-semantic-interposition

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

2023-08-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG31873d3fca38: [include-cleaner] Handle files with unnamed buffers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157078/new/ https://

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

2023-08-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: ChuanqiXu. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Some tools can register virtual buffe