[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a subscriber: eandrews. aaron.ballman added a comment. Thank you for the revert -- I've confirmed it fixed the issues for our downstream. Also, @eandrews said she may try to tackle the underlying issue with builtins in the relatively near future. Repository: rG LLVM

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-04 Thread Aiden Grossman via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf3baf63d9a1b: Revert [clang][X86] Add __cpuidex function to cpuid.h (authored by aidengrossman). Changed prior to

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-04 Thread Aiden Grossman via Phabricator via cfe-commits
aidengrossman added a comment. Thanks for the quick response! Sorry for all the churn with this patch. I'm fine leaving this out of LLVM 17, so I'll land this patch, backport the commit to the 17 release branch, and then once we have the aux triple and MS extensions flag fixes I'll reland in

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-04 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D157115#4561497 , @aaron.ballman wrote: > Thank you for this! The revert LGTM, but please wait for @mstorsjo to confirm > this won't cause problems for MinGW folks. I guess this is fine. We should probably sync mingw-w64

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for this! The revert LGTM, but please wait for @mstorsjo to confirm this won't cause problems for MinGW folks. In terms of solving the underlying issue with aux triple so that we can re-land this, I went digging to see if there's an existing issue

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-04 Thread Aiden Grossman via Phabricator via cfe-commits
aidengrossman added a comment. Assuming everyone agrees to this going in, I'll land it and then open a backport for the 17 release and reland once the auxiliary triple issues are resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157115/new/

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-04 Thread Aiden Grossman via Phabricator via cfe-commits
aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 2df77ac20a1ed996706b164b0c4ed5ad140f635f