This revision was automatically updated to reflect the committed changes.
Closed by commit rG2553e2403a33: [clang-tidy] Fix false-positives in
performanc-noexcept-swap (authored by PiotrZSL).
Changed prior to commit:
https://reviews.llvm.org/D157185?vs=547528=547537#toc
Repository:
rG LLVM
PiotrZSL updated this revision to Diff 547528.
PiotrZSL added a comment.
Remove space
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157185/new/
https://reviews.llvm.org/D157185
Files:
PiotrZSL updated this revision to Diff 547526.
PiotrZSL marked 3 inline comments as done.
PiotrZSL added a comment.
Fix comments + add test with friend
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157185/new/
https://reviews.llvm.org/D157185
carlosgalvezp added inline comments.
Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:31
+ // Match function with 2 arguments, both are non-const references to same
type
+ // and return void void swap(Type&, Type&)
+ auto FunctionMatcher = allOf(
PiotrZSL updated this revision to Diff 547502.
PiotrZSL added a comment.
Rebase, add comments, make more strict for method (must be non-const)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157185/new/
https://reviews.llvm.org/D157185
Files:
carlosgalvezp accepted this revision.
carlosgalvezp added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:22
Finder->addMatcher(
- functionDecl(unless(isDeleted()),
PiotrZSL created this revision.
PiotrZSL added reviewers: njames93, carlosgalvezp, AMS21.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Enforce a
