This revision was automatically updated to reflect the committed changes.
Closed by commit rG2111577d4dfc: [clang-tidy] Fixed false-negative in
readability-identifier-naming (authored by PiotrZSL).
Changed prior to commit:
https://reviews.llvm.org/D157190?vs=547503=547536#toc
Repository:
rG
PiotrZSL updated this revision to Diff 547503.
PiotrZSL added a comment.
Rebase + make tests more simple
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157190/new/
https://reviews.llvm.org/D157190
Files:
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming.cpp:716
+// CHECK-FIXES: {{^}}class CClassWithForwardDecl {
+class class_with_forward_decl {
+ int __value;
carlosgalvezp wrote:
> Nit:
carlosgalvezp accepted this revision.
carlosgalvezp added a comment.
This revision is now accepted and ready to land.
LGTM, minor question that can be fixed post-review unless you want to discuss
further!
Comment at:
PiotrZSL updated this revision to Diff 547475.
PiotrZSL edited the summary of this revision.
PiotrZSL added a comment.
Properly handle situation when class is forward-declared as struct.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157190/new/
PiotrZSL created this revision.
PiotrZSL added reviewers: carlosgalvezp, njames93.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Issue were cased by
