[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. In D157283#4648242 , @ldionne wrote: > As explained in https://reviews.llvm.org/D89001#4648241, upstream Clang is > the way it should be right now. The intent is that we first look along the > `clang` binary for headers

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

ldionne added a comment. In D157283#4614177 , @DmitryPolukhin wrote: > @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa > (I > don't know what it is)? >

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa (I don't know what it is)? Alternatively I can figure out what to do with this test (it is just copies of the same

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

arphaman added a comment. I will revert this for now, as this change broke Darwin CI: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/37169/ Clang.Tooling.clang-check-mac-libcxx-abspath.cpp Clang.Tooling.clang-check-mac-libcxx-relpath.cpp @ldionne has a patch for these

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

jroelofs added a comment. In D157283#4611447 , @PiotrZSL wrote: > I don't know how, but somehow this change breaks > clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test. I think we have a patch for that... @ldionne WDYT about upstreaming

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

PiotrZSL added a comment. I don't know how, but somehow this change breaks clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24aa691aa4f: [clang] Match -isysroot behaviour with system compiler on Darwin (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne, @arphaman and @jroelofs, friendly ping, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin updated this revision to Diff 547825. DmitryPolukhin added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

dexonsmith resigned from this revision. dexonsmith added subscribers: arphaman, jroelofs. dexonsmith added a comment. This looks correct to me, but I'd rather have someone at Apple confirm. @ldionne (or @arphaman or @jroelofs), can you review and/or help to find the right person? Repository:

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: ldionne, dexonsmith, MaskRay. DmitryPolukhin added a project: clang. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber: cfe-commits. See discussion in