This revision was automatically updated to reflect the committed changes.
Closed by commit rGd43a3d634696: [CodeGen] Restrict addEmittedDeferredDecl to
incremental extensions (authored by Hahnfeld).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rjmccall accepted this revision.
rjmccall added a comment.
Thank you, this seems reasonable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157379/new/
https://reviews.llvm.org/D157379
___
cfe-commits
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
@Hahnfeld, let's move forward and rely on a post-commit review here if
necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
v.g.vassilev added a comment.
This LGTM but I'd like to wait for @rjmccall for a week or so.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157379/new/
https://reviews.llvm.org/D157379
___
cfe-commits
Hahnfeld created this revision.
Hahnfeld added reviewers: rjmccall, v.g.vassilev, junaire.
Herald added a project: All.
Hahnfeld requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Reemission is only needed in incremental mode. With this early
