[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

This revision was automatically updated to reflect the committed changes. vhscampos marked an inline comment as done. Closed by commit rGd77cba6d474a: [Clang][DebugInfo] Emit narrower base types for structured binding declarations… (authored by vhscampos). Repository: rG LLVM Github Monorepo C

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added a comment. New test LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/ https://reviews.llvm.org/D157479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos marked an inline comment as done. vhscampos added a comment. @aprantl We have discussed internally a few options to implement correct debug information in this case. But this will be future work. For the time being, we believe it is better to have no debug information rather than wron

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos updated this revision to Diff 550298. vhscampos added a comment. - Redone test to cover only what's needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/ https://reviews.llvm.org/D157479 Files: clang/lib/CodeGen/CGDebugInfo

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added a comment. > If no suitable integer type is found in the target, no debug information is > emitted anymore in order to prevent wrong debug output. Why is emitting a bitfield type not an option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-structured-binding-bitfield.cpp:525 +// CHECK: !202 = !DILocation(line: 279, column: 8, scope: !194) +// CHECK: !203 = !DILocation(line: 279, column: 17, scope: !194) +// CHECK: !204 = !DILocation(line: 2

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos marked 3 inline comments as done. vhscampos added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-structured-binding-bitfield.cpp:6 + unsigned int y : 16; +}; + tmatheson wrote: > This would be easier to check if the structs had meaningfu

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos updated this revision to Diff 549359. vhscampos added a comment. - Addressed the one comment regarding code. - Changed the test to use update_cc_test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/ https://reviews.llvm.org/D1574

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM with a few cosmetic suggestions. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4772 +QualType FinalTy = Context.getQualifiedType(IntTy, Quals); +Ty

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos created this revision. Herald added a project: All. vhscampos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In cases where a structured binding declaration is made to a struct with bitfields: struct A { unsigned int x : 16;