This revision was automatically updated to reflect the committed changes.
Closed by commit rGf8431a0e4008: Avoid running optimization passes in frontend
test (authored by MatzeB).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157518/new/
wenlei accepted this revision.
wenlei added a comment.
lgtm, thanks.
Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148
-// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32
[[LIKELY]]}
-// CHECK: ![[PROF_UNLIKELY]] =
MatzeB marked 2 inline comments as done.
MatzeB added inline comments.
Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148
-// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32
[[LIKELY]]}
-// CHECK: ![[PROF_UNLIKELY]] =
aeubanks added inline comments.
Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148
-// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32
[[LIKELY]]}
-// CHECK: ![[PROF_UNLIKELY]] = !{!"branch_weights", i32 [[LIKELY]], i32
wenlei added inline comments.
Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148
-// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32
[[LIKELY]]}
-// CHECK: ![[PROF_UNLIKELY]] = !{!"branch_weights", i32 [[LIKELY]], i32
MatzeB updated this revision to Diff 548657.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157518/new/
https://reviews.llvm.org/D157518
Files:
clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp
Index:
aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.
seems fine if nobody else objects
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157518/new/
https://reviews.llvm.org/D157518
MatzeB updated this revision to Diff 548655.
MatzeB added a comment.
Decided to just use "utils/update_cc_test_checks.py" so we can inspect the
generate llvm.expect calls directly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157518/new/
MatzeB created this revision.
MatzeB added reviewers: wenlei, Mordante, aeubanks, hoy.
Herald added subscribers: modimo, mcrosier.
Herald added a project: All.
MatzeB requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Only run "lower-expect"
