This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb2cd9db58933: [clang][Sema] Remove irrelevant diagnostics
from constraint satisfaction failure (authored by hazohelet).
Changed prior to commit:
h
hazohelet added a comment.
When I first ran `git clang-format` locally, it somehow forced 4-space indent.
After starting to use clang-format from the trunk, I haven't seen the
suspicious behavior locally, but the CI format check failure might be caused by
that.
The format seems okay as-is, so I'
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
I think this is alright. Please see if you can figure out and fix what the
pre-commit clang-format issue is.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157526/new/
https:
cor3ntin added a comment.
LGTM, but please wait a few days for @erichkeane
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157526/new/
https://reviews.llvm.org/D157526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
hazohelet updated this revision to Diff 556227.
hazohelet marked an inline comment as done.
hazohelet added a comment.
Added comment and FIXME
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157526/new/
https://reviews.llvm.org/D157526
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sem
cor3ntin added a comment.
Given that we still need to check for substitution errors in untaken branches,
this look reasonable (especially as i think you are right that alternative
approaches are likely to be more complex) however i think it does require a
comment, and I'd like @erichkeane to ha
hazohelet added a comment.
To generate only the necessary diagnostic information, we need to know the
evaluation result of the entire constraint expression.
So, the ideal way I can think of would be first to evaluate the nodes and,
simultaneously, cache the results using `DenseMap` or something,
erichkeane added a comment.
Sorry for the delay in review, I'm still on vacation. However, I don't like
the idea of removing the satisfaction. I have to think about it more, but
optimally we'd just not add the detail until we knew what the RHS value was,
though our design doesn't particularly
hazohelet added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157526/new/
https://reviews.llvm.org/D157526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
tbaeder added a comment.
Generally LGTM, but the `erase` call could do with a comment before. And I'll
let someone with more concepts experience handle whether this should be
accepted or not.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157526/ne
hazohelet created this revision.
hazohelet added reviewers: aaron.ballman, erichkeane, tbaeder, shafik.
Herald added a project: All.
hazohelet requested review of this revision.
Herald added a project: clang.
BEFORE this patch, when clang handles constraints like `C1 || C2` where `C1`
evaluates t
11 matches
Mail list logo