[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf52f8e817ea3: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D157632?vs=550051=554035#toc Repository: rG LLVM

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

vitalybuka added a comment. Reverted cd591e02d4563d4b90792ed5f441e1cf5b30443e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. reverted in 9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: >

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; ellis wrote: >

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: >

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: >

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; we're running into

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2cf195d5fb: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 550039. zequanwu marked 3 inline comments as done. zequanwu added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files:

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c:24 + +// RUN: rm -rf %t.profdir && mkdir %t.profdir + Let's move this line down since we don't use it until line 31. Comment at:

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4581219 , @ellis wrote: > In D157632#4580576 , @zequanwu > wrote: > >> BTW, I noticed something strange with `-pgo-function-entry-coverage` when >> merging via

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. In D157632#4580576 , @zequanwu wrote: > BTW, I noticed something strange with `-pgo-function-entry-coverage` when > merging via llvm-profdata. This is intentional. The two raw profiles individually store blocks as either covered

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. BTW, I noticed something strange with `-pgo-function-entry-coverage` when merging via llvm-profdata. In this file `compiler-rt/test/profile/Linux/instrprof-debug-info-correlate.c`, I ran the following: // RUN: %clang_pgogen -o %t.cov.normal -mllvm

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4578582 , @ellis wrote: > I've just published https://reviews.llvm.org/D157664, so you'll want to > rebase ontop of it if it lands soon. I would also like to see some more tests > added to `instrprof-merge-error.c`

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:129 + // enabled. + if (Header->DataSize == 0) { +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { ellis wrote: > Since we don't have the data

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 549424. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files:

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. I've just published https://reviews.llvm.org/D157664, so you'll want to rebase ontop of it if it lands soon. I would also like to see some more tests added to `instrprof-merge-error.c` to make sure two different binaries can't merge profiles together with

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. Thanks for working on this! Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:103-104 COMPILER_RT_VISIBILITY int __llvm_profile_merge_from_buffer(const char *ProfileData, uint64_t ProfileSize) {

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 549077. zequanwu added a comment. Remove debug includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu created this revision. zequanwu added reviewers: ellis, MaskRay, davidxl. Herald added subscribers: Enna1, ormris. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. When