[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

2023-08-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov abandoned this revision. ilya-biryukov added a comment. Thanks for clarifying! I misread the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157708/new/ https://reviews.llvm.org/D157708

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

2023-08-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. The prior behavior of Clang is correct. A search of a class scope is ill-formed if it finds an ambiguous result, see http://eel.is/c++draft/basic.lookup#class.member.lookup-6.sentence-2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

2023-08-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a reviewer: clang-language-wg. ilya-biryukov added a comment. @shafik, @rsmith friendly ping for a review. Also adding clang-language-wg for a wider set of potential reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

2023-08-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:967 S.getScopeForContext(EqFD->getEnclosingNamespaceContext())); NonMembers.suppressAccessDiagnostics(); for (NamedDecl *Op : NonMembers) { I believe we should

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

2023-08-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: shafik, rsmith. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The standard specified that Clang should 'search' for members in