This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
kadircet marked 3 inline comments as done.
Closed by commit rG373fcd5d73a3: [clang] Use RecoveryExprs for broken
defaultargs, instead of OpaqueValueExprs (authored by
sammccall accepted this revision.
sammccall added a comment.
Still LG once you're happy
Comment at: clang/include/clang/Sema/Sema.h:3026
+ void ActOnParamDefaultArgumentError(Decl *param, SourceLocation EqualLoc,
+ ExprResult DefaultArg);
kadircet added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:3026
+ void ActOnParamDefaultArgumentError(Decl *param, SourceLocation EqualLoc,
+ ExprResult DefaultArg);
ExprResult ConvertParamDefaultArgument(ParmVarDecl
kadircet updated this revision to Diff 549939.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Use Expr* instead of ExprResult
- Add dump test to demonstrate new RecoveryExpr
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, recoveryexpr is a better fit here. These changes tend to cause occasional
new error-handling crashes on under-tested paths, but I guess it's a good time
in the release cycle for
kadircet created this revision.
kadircet added reviewers: sammccall, aaron.ballman.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.
This makes
