This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.
Closed by commit rG90ecadde62f3: [include-cleaner] Filter references to
identity macros (authored by kadircet).
Changed prior to commit:
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:44
+ // not the macro definition. So ignore such macros.
+ return MI && MI->getNumTokens() == 1 && MI->isObjectLike() &&
+
kadircet updated this revision to Diff 550790.
kadircet added a comment.
Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman.
Herald added a reviewer: njames93.
- Apply filtering only to macros that expand to themselves
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kadircet marked 2 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43
+ // This results in surprising behavior from users point of view (we
+ // generate a usage of stdio.h, in places unrelated to
sammccall accepted this revision.
sammccall added a comment.
still LG, comments are still confusing me a little
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43
+ // This results in surprising behavior from users point of view (we
+ // generate a
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43
+ // This results in surprising behavior from users point of view (we
+ // generate a usage of stdio.h, in places unrelated to
kadircet updated this revision to Diff 550662.
kadircet marked an inline comment as done.
kadircet added a comment.
- Rename helper, update comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157905/new/
https://reviews.llvm.org/D157905
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:37
+namespace {
+bool shouldSkipMacro(const Macro ) {
+ static const auto *MacroNamesToIgnore = new
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Despite being true positives, these results just confuse users. So
