[PATCH] D157963: [clang-format] Annotate constructor/destructor names

This revision was automatically updated to reflect the committed changes. Closed by commit rG086305120887: Reland [clang-format] Annotate constructor/destructor names (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan updated this revision to Diff 554051. owenpan added a comment. Fixed the crash and added a test case in `TokenAnnotatorTest.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/ https://reviews.llvm.org/D157963 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3135 + if (!Tok) +break; +} When simplifying the function, I forgot that we are in the inner loop here and thus `break` won't exit the outer loop. Repository: rG

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

kadircet added a comment. In D157963#4621206 , @HazardyKnusperkeks wrote: > @kadircet shouldn't you at least say why it got reverted? Even better state > your problem and give a chance to fix before you revert? Hi,

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

HazardyKnusperkeks added a subscriber: kadircet. HazardyKnusperkeks added a comment. @kadircet shouldn't you at least say why it got reverted? Even better state your problem and give a chance to fix before you revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e63f1aacc00: [clang-format] Annotate constructor/destructor names (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan updated this revision to Diff 551019. owenpan added a comment. Rebased to D158104 and simplified `getFunctionName` and `isCtorOrDtorName` a little. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/ https://reviews.llvm.org/D157963

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3103 + if (!Next) +return Next; + if (Next->is(tok::comment)) owenpan wrote: > HazardyKnusperkeks wrote: > > Is a bit clearer. > I moved this function up to here from below and

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3103 + if (!Next) +return Next; + if (Next->is(tok::comment)) HazardyKnusperkeks wrote: > Is a bit clearer. I moved this function up to here from below and only removed a couple

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:3103 + if (!Next) +return Next; + if (Next->is(tok::comment)) Is a bit

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Annotate constructor/destructor names as