yaxunl closed this revision.
yaxunl added a comment.
Phabricator no longer allows me to update the patch. Created PR in github
https://github.com/llvm/llvm-project/pull/65606
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158247/new/
yaxunl reopened this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
The patch was reverted since it caused regressions on Windows for HIP. A
reduced test case is:
typedef void (__stdcall* funcTy)();
void invoke(funcTy f);
static void __stdcall
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGde0df639724b: [CUDA][HIP] Fix overloading resolution in
global variable initializer (authored by yaxunl).
Herald added a project: clang.
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158247/new/
https://reviews.llvm.org/D158247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 551705.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
revised by comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158247/new/
https://reviews.llvm.org/D158247
Files:
clang/include/clang/Sema/Sema.h
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:4753
+ /// Otherwise, use \p D to determiine the host/device target.
bool CheckCallingConvAttr(const ParsedAttr , CallingConv ,
+
tra added a comment.
Same reproducer but for CUDA: https://godbolt.org/z/WhjTMffnx
Comment at: clang/include/clang/Sema/Sema.h:4753
+ /// Otherwise, use \p D to determiine the host/device target.
bool CheckCallingConvAttr(const ParsedAttr , CallingConv ,
+
yaxunl created this revision.
yaxunl added reviewers: tra, rjmccall, rsmith.
Herald added subscribers: mattd, carlosgalvezp, kerbowa, jvesely.
Herald added a reviewer: aaron.ballman.
Herald added a project: All.
yaxunl requested review of this revision.
Currently, clang does not resolve certain
