[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1468-1477 std::optional getRangeForNegatedSymSym(const SymSymExpr *SSE) { return getRangeForNegatedExpr( [SSE, State = this->State]() -> SymbolRef {

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/InterpBlock.cpp:94-95 DeadBlock::DeadBlock(DeadBlock *, Block *Blk) -: Root(Root), B(Blk->Desc, Blk->IsStatic, Blk->IsExtern, /*isDead=*/true) { +: Root(Root), B(Blk->Desc, Blk->IsExtern,

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

aaron.ballman added a comment. In D158285#4603521 , @steakhal wrote: > In D158285#4603477 , @aaron.ballman > wrote: > >>> I've seen a few similar patches from you @Manna and probably some related >>> folks. >>>

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

tahonermann added a comment. > To me, an important metric of a quality patch is if the title and the summary > describe why we have this patch, and what we do about it. @steakhal, I'll work with the people submitting these patches to add more context to the title, summary, and commit comments.

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

steakhal added a comment. In D158285#4603477 , @aaron.ballman wrote: >> I've seen a few similar patches from you @Manna and probably some related >> folks. >> Could you please clarify the motivation and the expectations? Or feel free >> to point me to

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18098-18101 case OMPC_allocate: Res = ActOnOpenMPAllocateClause(Data.DepModOrTailExpr, VarList, StartLoc, -LParenLoc, ColonLoc, EndLoc); +

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

aaron.ballman added a comment. > I've seen a few similar patches from you @Manna and probably some related > folks. > Could you please clarify the motivation and the expectations? Or feel free to > point me to the Discuss post around the subject if I happened to miss it. Intel has been

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

steakhal requested changes to this revision. steakhal added subscribers: tbaeder, ABataev. steakhal added a comment. This revision now requires changes to proceed. I think we have two 2 TPs, that were interesting to see. I've CCd the code owners of the affected parts to confirm this. As a

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo