[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rGf465a482caa9: [clang-format] Fix segmentation fault when formatting nested namespaces (authored by d0nc1h0t, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t added a comment. In D158363#463 , @owenpan wrote: > We need the name and email you want to use in order to commit the patch for > you. Arkadiy Yudintsev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan added a comment. We need the name and email you want to use in order to commit the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 ___

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t added a comment. In D158363#4632451 , @owenpan wrote: > Do you need us to commit it for you? See > https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. 'git push' or 'arc land' give an error 'remote: Permission

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 555317. d0nc1h0t added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan added a comment. Do you need us to commit it for you? See https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t marked an inline comment as done. d0nc1h0t added a comment. Fixed. (Relied on auto-formatting in the IDE) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 553085. d0nc1h0t added a comment. Added missing const + clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files:

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:389 auto *ClosingLine = AnnotatedLines.begin() + ClosingLineIndex + 1; - auto OutdentBy =

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 553017. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. It seems that you forgot to update the diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:389 auto *ClosingLine = AnnotatedLines.begin() + ClosingLineIndex + 1; auto OutdentBy = I[J]->Level - TheLine->Level; for (auto *CompactedLine = I + J;

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 552604. d0nc1h0t added a comment. Updated the patch with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files:

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

HazardyKnusperkeks added a comment. In D158363#4606159 , @d0nc1h0t wrote: > In D158363#4604468 , > @HazardyKnusperkeks wrote: > >> Please upload the patch with the full context. > > I'm creating a patch via 'git

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t added a comment. In D158363#4604468 , @HazardyKnusperkeks wrote: > Please upload the patch with the full context. I'm creating a patch via 'git diff' from the root of the project. What does full context mean? Repository: rG LLVM Github

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 552281. d0nc1h0t added a comment. Added unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

HazardyKnusperkeks added a comment. Please upload the patch with the full context. And add a test case. (From your issue.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t created this revision. d0nc1h0t added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a comment. d0nc1h0t requested review of this revision. NOTE: