This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3116d60494f2: [Lex] Introduce
Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
Hahnfeld added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:1000
+ std::vector toks;
+ while (1) {
+Token tok;
v.g.vassilev wrote:
> Hahnfeld wrote:
> > aaron.ballman wrote:
> > > v.g.vassilev wrote:
> > > > aaron.ballman wrote:
> > > > >
Hahnfeld updated this revision to Diff 557603.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Address minor naming convention nit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158413/new/
https://reviews.llvm.org/D158413
Files:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a minor naming nit. I think finding a way to unify with
`SkipUntil` would be good follow-up work, though.
Comment at:
v.g.vassilev added a comment.
This looks reasonable to me, but I'd wait for @aaron.ballman greenlight as he
seems to have had more comments/ideas.
Comment at: clang/lib/Lex/Preprocessor.cpp:1000
+ std::vector toks;
+ while (1) {
+Token tok;
Hahnfeld
Hahnfeld added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158413/new/
https://reviews.llvm.org/D158413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:1000
+ std::vector toks;
+ while (1) {
+Token tok;
aaron.ballman wrote:
> v.g.vassilev wrote:
> > aaron.ballman wrote:
> > > Hahnfeld wrote:
> > > > aaron.ballman wrote:
> > > > >
Hahnfeld updated this revision to Diff 556834.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Handle all of `tok::unknown, tok::eof, tok::eod`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158413/new/
https://reviews.llvm.org/D158413
Files:
aaron.ballman added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:1000
+ std::vector toks;
+ while (1) {
+Token tok;
v.g.vassilev wrote:
> aaron.ballman wrote:
> > Hahnfeld wrote:
> > > aaron.ballman wrote:
> > > > I'd prefer not to assume
v.g.vassilev added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:1000
+ std::vector toks;
+ while (1) {
+Token tok;
aaron.ballman wrote:
> Hahnfeld wrote:
> > aaron.ballman wrote:
> > > I'd prefer not to assume the token stream has an EOF
aaron.ballman added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:1000
+ std::vector toks;
+ while (1) {
+Token tok;
Hahnfeld wrote:
> aaron.ballman wrote:
> > I'd prefer not to assume the token stream has an EOF token (perhaps the
> >
Hahnfeld marked 2 inline comments as done.
Hahnfeld added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:998
+std::vector Preprocessor::LexAll() {
+ std::vector toks;
aaron.ballman wrote:
> v.g.vassilev wrote:
> > Shouldn't we take the results as
Hahnfeld updated this revision to Diff 556791.
Hahnfeld retitled this revision from "[Lex] Introduce Preprocessor::LexAll()"
to "[Lex] Introduce Preprocessor::LexTokensUntilEOF()".
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
Rename to
13 matches
Mail list logo
