[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG158f4f30adb4: [Clang] Do not change the type of captured vars when checking lambda constraints (authored by cor3ntin). Repository: rG LLVM Github

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158433/new/ https://reviews.llvm.org/D158433

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin updated this revision to Diff 553047. cor3ntin added a comment. Missing curlies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158433/new/ https://reviews.llvm.org/D158433 Files: clang/include/clang/Sema/Sema.h

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

erichkeane added a comment. I agree with this approach, and think we should backport this if at all possible. The original solution is a bit problematic, and I don't believe this solution is particularly risky. Comment at: clang/lib/Sema/SemaConcept.cpp:727 + } else +

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin added a comment. @aaron.ballman Should we land that? it already missed rc3... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158433/new/ https://reviews.llvm.org/D158433 ___ cfe-commits mailing

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin updated this revision to Diff 552329. cor3ntin added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158433/new/ https://reviews.llvm.org/D158433 Files: clang/include/clang/Sema/Sema.h

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:722 +const_cast(cast(FD))); +// Captures are not checked from within the lambda. +LSI->AfterParameterList = false; shafik wrote: > This comment does not really explain to

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

shafik added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:722 +const_cast(cast(FD))); +// Captures are not checked from within the lambda. +LSI->AfterParameterList = false; This comment does not really explain to me the effect of

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

aaron.ballman added reviewers: erichkeane, hubert.reinterpretcast, clang-language-wg. aaron.ballman added a comment. Adding a few more reviewers for extra sets of eyes given that we'd like this to land in 17.x. The changes look correct to me, but a confirmation would be appreciated.

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When checking the constraint of a lambda, we need to respect the constness of the