[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Sindhu Chittireddy via Phabricator via cfe-commits
schittir abandoned this revision. schittir added a comment. In D158488#4607754 , @Manna wrote: > This has already been addressed by https://reviews.llvm.org/D157989 Thank you for letting me know. Abandoning this change. CHANGES SINCE LAST ACTION http

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. This has already been addressed by https://reviews.llvm.org/D157989 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:934 // Return value of the runtime offloading call. - Value *Return; + Value *Return =

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Sindhu Chittireddy via Phabricator via cfe-commits
schittir updated this revision to Diff 552380. schittir added a comment. Remove unnecessary initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 Files: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp Index: llvm/lib/Frontend/OpenMP/OM

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Sindhu Chittireddy via Phabricator via cfe-commits
schittir marked 2 inline comments as done. schittir added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2606-2607 enum { INIT, CONDVAR, COND, INC, BODY, END_EXPR }; - Stmt* SubExprs[END_EXPR]; // SubExprs[INIT] is an expression or declstmt. + Stmt *SubExprs[END

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2606-2607 enum { INIT, CONDVAR, COND, INC, BODY, END_EXPR }; - Stmt* SubExprs[END_EXPR]; // SubExprs[INIT] is an expression or declstmt. + Stmt *SubExprs[END_EXPR] = { + nullptr}; // SubExprs[

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2606-2607 enum { INIT, CONDVAR, COND, INC, BODY, END_EXPR }; - Stmt* SubExprs[END_EXPR]; // SubExprs[INIT] is an expression or declstmt. + Stmt *SubExprs[END_EXPR] = { + nullptr}; // SubExpr

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

2023-08-21 Thread Sindhu Chittireddy via Phabricator via cfe-commits
schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a subscriber: hiraditya. Herald added a project: All. schittir requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc. Herald added projects: clang, LLVM. Repo