This revision was automatically updated to reflect the committed changes.
Closed by commit rG847186eb94bd: [NFC][Clang] Fix static analyzer concern
(authored by eandrews).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
eandrews updated this revision to Diff 553534.
eandrews added a comment.
Thanks for the reviews! Requested changes have been made in latest patch
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158671/new/
https://reviews.llvm.org/D158671
Files:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM with some nits
Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:195
SymbolReference Context;
-auto Record = dyn_cast(Decl->getDeclContext());
+auto Record =
Fznamznon added inline comments.
Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:610-612
if (isa(Method)) {
Name = Method->getNameAsString();
+if (cast(Method)->isExplicit())
Maybe we can just do this, so we don't `isa` two times.
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:195
SymbolReference Context;
-auto Record = dyn_cast(Decl->getDeclContext());
+auto Record =
eandrews created this revision.
eandrews added reviewers: aaron.ballman, tahonermann.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
a.sidorin, baloghadamsoftware.
Herald added a reviewer: ributzka.
Herald added a project: All.
eandrews requested review of this
