This revision was automatically updated to reflect the committed changes.
Closed by commit rGbbcc7c5614cd: [NFC] Initialize member pointer and avoid
potential null dereference (authored by schittir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
schittir added a comment.
Thank you for the reviews, Aaron and Aaron!
All tests pass. Landing the patch now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158775/new/
https://reviews.llvm.org/D158775
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM though I can take or leave the changes to ThreadSafety.cpp.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:2243
const auto *CurrentFunction =
aaronpuchert added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:2243
const auto *CurrentFunction = dyn_cast(D);
CurrentMethod = dyn_cast(D);
It seems to me that `CurrentMethod` is unconditionally assigned a value here,
before it is
schittir created this revision.
schittir added reviewers: aaron.ballman, tahonermann.
Herald added a reviewer: NoQ.
Herald added a project: All.
schittir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
