[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-30 Thread Louis Dionne via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb27be95a4c6: [clang] Add a Windows build in the Clang pre-commit

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-30 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. This looks good, the Windows CI is failing with the original premerge checks in exactly the same way as this new job, so I guess it's a current issue on `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-29 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 554295. ldionne added a comment. Poke CI -- Phabricator keeps timing out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-29 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 554277. ldionne added a comment. Don't upload the Windows build artifacts cause we don't use them and it fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-28 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 554115. ldionne added a comment. Poke CI -- it seemed to time out this afternoon due to Phab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-28 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 554015. ldionne added a comment. Set VC variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-28 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 553995. ldionne added a comment. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-buildbot

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-28 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 553968. ldionne added a comment. Run script through bash on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D158995#4621441 , @ldionne wrote: > @aaron.ballman for awareness Thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-28 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a subscriber: aaron.ballman. ldionne added a comment. @aaron.ballman for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 ___

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

2023-08-28 Thread Louis Dionne via Phabricator via cfe-commits
ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a CI job for Clang on Windows that is separate from the monolithic job that gets added automatically via