[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

2023-08-28 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. Reverted. Please continue on original review: `arc diff HEAD^ --revision D157632` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

2023-08-28 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. Could this be related https://lab.llvm.org/buildbot/#/builders/127/builds/54239 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

2023-08-28 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. It's more convenient if you upload new patches into original review and reland that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

2023-08-28 Thread Zequan Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGd80992032fd0: Reland [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Changed prior to commit:

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

2023-08-28 Thread Ellis Hoag via Phabricator via cfe-commits
ellis accepted this revision. ellis added a comment. This revision is now accepted and ready to land. Thanks for adding the test case! Can you also link the original diff in the summary? Comment at: compiler-rt/test/profile/instrprof-merge-empty-data.test:1 +// Test +// RUN:

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

2023-08-28 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. looks fine to me but I'll let ellis lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 ___ cfe-commits mailing list

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

2023-08-28 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added reviewers: ellis, aeubanks. Herald added subscribers: Enna1, ormris. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Fixed the issue