[PATCH] D159018: [clang][modules] Add a c23 module feature

2023-08-29 Thread Ian Anderson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGadb68c979d84: [clang][modules] Add a c23 module feature (authored by iana). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/

[PATCH] D159018: [clang][modules] Add a c23 module feature

2023-08-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. In D159018#4623880 , @v.g.vassilev wrote: > LGTM! > > In D159018#4622598 , @iana wrote: > >> Would we want to back port this to llvm 17? > >

[PATCH] D159018: [clang][modules] Add a c23 module feature

2023-08-29 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! In D159018#4622598 , @iana wrote: > Would we want to back port this to llvm 17? Yes probably. Repository: rG LLVM Github

[PATCH] D159018: [clang][modules] Add a c23 module feature

2023-08-28 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 554158. iana added a comment. remove the extra #endif (which oddly didn't produce an error locally so I must've ran the tests wrong the first time...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/

[PATCH] D159018: [clang][modules] Add a c23 module feature

2023-08-28 Thread Ian Anderson via Phabricator via cfe-commits
iana added a comment. Would we want to back port this to llvm 17? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/ https://reviews.llvm.org/D159018 ___ cfe-commits mailing list

[PATCH] D159018: [clang][modules] Add a c23 module feature

2023-08-28 Thread Ian Anderson via Phabricator via cfe-commits
iana created this revision. iana added reviewers: ChuanqiXu, Bigcheese, v.g.vassilev, aaron.ballman. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a c23 module