[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG400d3261a0da: [HLSL] Cleanup support for `this` as an l-value (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I like this as a simplification, too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159247/new/

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz updated this revision to Diff 555380. beanz added a comment. Updating based on PR feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159247/new/ https://reviews.llvm.org/D159247 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

shafik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2174 + static QualType getThisType(const FunctionProtoType *FPT, cor3ntin wrote: > Whitespace only change Spurious change. Comment at:

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. I would like @aaron.ballman to weight in, (he might not get back to you until next week), but overall, i think I'm pretty happy with this new direction. Comment at: clang/include/clang/AST/DeclCXX.h:2174 + static QualType getThisType(const

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz updated this revision to Diff 555118. beanz added a comment. Updating based on review feedback from @core3ntin. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159247/new/ https://reviews.llvm.org/D159247 Files:

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz added a comment. Yea, we could do that approach. It will mean filtering about a few `getNonReferenceType()` calls, which is what I was trying to avoid. That said, it might be the better solution since it can be unconditional and will work for both deducing `this` and HLSL. I'll test it

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. Thanks for working on this. This is going to conflict with deducing this (https://reviews.llvm.org/D140828) in interesting (ie, horrible) ways, so i guess I'll have to deal with that. For people following along we are trying to fix nasty lambda regression

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz added a comment. Full disclosure here, I need to write some more tests for this. It should be NFC for all languages other than HLSL, but I want to spend some time making sure that the tests adequately exercise the HLSL paths (which should also be mostly NFC). Repository: rG LLVM

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz created this revision. beanz added reviewers: cor3ntin, aaron.ballman, bogner. Herald added subscribers: Anastasia, ChuanqiXu, martong. Herald added a reviewer: shafik. Herald added a reviewer: NoQ. Herald added a project: All. beanz requested review of this revision. Herald added a project: