[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1e3cd1d7944: [driver] Conditionally include installed libc++ headers for Android (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159292

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159292/new/ https://reviews.llvm.org/D159292 ___

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai added a comment. In D159292#4646811 , @rprichard wrote: > In D159292#4646096 , @smeenai wrote: > >> Ping. > > I asked a couple of other people at Google to take a look at the patches. > Someone should get

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

rprichard added a comment. In D159292#4646096 , @smeenai wrote: > Ping. I asked a couple of other people at Google to take a look at the patches. Someone should get to it next week I think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159292/new/ https://reviews.llvm.org/D159292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai added a comment. In D159292#4632389 , @rprichard wrote: > This change looks like an improvement to me. The NDK currently puts the > libc++ headers into the sysroot, but putting it in the usual toolchain > include location seems better. Are you

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai updated this revision to Diff 555246. smeenai added a comment. Rebase to avoid pre-existing CI failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159292/new/ https://reviews.llvm.org/D159292 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

glandium resigned from this revision. glandium added a comment. This + D159293 works great for me. Thanks a bunch. (I'm not a reviewer, though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159292/new/ https://re

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3108 +SmallString<128> TargetDir(Path); +llvm::sys::path::append(TargetDir, Target, "c++", Version); if (D.getVFS().exists(TargetDir)) rprichard wrote: > Will the `Target`

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

rprichard added a comment. This change looks like an improvement to me. The NDK currently puts the libc++ headers into the sysroot, but putting it in the usual toolchain include location seems better. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3108 +SmallString<128>

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai created this revision. smeenai added reviewers: danalbert, srhines, pcc, phosek, thakis, MaskRay, glandium. Herald added a subscriber: danielkiss. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.