[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. In D159339#4642210 , @v.g.vassilev wrote: > In D159339#4642147 , @daltenty > wrote: > >> FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and >> didn't see it at

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev added a comment. In D159339#4642147 , @daltenty wrote: > FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and didn't > see it at this point, though I get a whole lot of other uninitialized reads, > so there's definitely

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and didn't see it at this point, though I get a whole lot of other uninitialized reads, so there's definitely some general problems in this space in the LLVM codebase Repository: rG LLVM Github

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev added a subscriber: Hahnfeld. v.g.vassilev added a comment. The issue goes away for non-CXXMethodDecls but still persists in the case where we process: CXXDestructorDecl 0x9ab0f48 col:11 implicit used ~shared_ptr 'void () noexcept' inline default `-CompoundStmt 0x9ac3ca0

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92246a9be0ba: [CodeGen] First check the kind and then the llvm::Function properties. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM as a workaround. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rjmccall, daltenty, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. v.g.vassilev requested review of this revision. Herald added a subscriber: wangpc. This patch fixes valgrind reports from