[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin added a comment. In D159345#4640147 , @tahonermann wrote: > Even better than I asked for. I held back on suggesting the change of `Tok` > to `Result` to match `tryConsumeIdentifierUCN()`, but you made that change > anyway! You must have read m

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb67d28dee5: [Clang] Handle non-ASCII after line splicing (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D159345?vs=55

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

tahonermann accepted this revision. tahonermann added a comment. Even better than I asked for. I held back on suggesting the change of `Tok` to `Result` to match `tryConsumeIdentifierUCN()`, but you made that change anyway! You must have read my mind! :) Repository: rG LLVM Github Monorepo

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin updated this revision to Diff 556076. cor3ntin added a comment. Address Tom's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs/ReleaseNotes.rst clang/include/clang/L

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks good to me modulo a couple of nits. Comment at: clang/include/clang/Lex/Lexer.h:806-807 /// Try to consume an identifier character encoded in UTF-8.

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

shafik added a comment. I think this looks good but I would like @tahonermann to review this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 ___ cfe-c

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1761 + getCharAndSize(CurPtr, FirstCodeUnitSize); + const char *CharStart = CurPtr + FirstCodeUnitSize - 1; + const char *UnicodePtr = CharStart; shafik wrote: > Do we need to verify that `Fir

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin updated this revision to Diff 63. cor3ntin marked an inline comment as done. cor3ntin added a comment. Add and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

shafik added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1757 + // If a UTF-8 codepoint appears immediately after an escaped new line, + // CurPtr may point to the splicing \ at the on the preceding line, + // so we need to skip it. I think that is wh

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. int a\ ス; Failed to be parsed as a valid identifier. Fixes #65156 Repository: rG LLVM Github Monorepo https://revie