[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-05 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/lib")); + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/develop/lib")); } trungnt29

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-05 Thread Trung Nguyen via Phabricator via cfe-commits
trungnt2910 added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:85-86 + "/boot/system/develop/headers/os/net")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, + "/boot/system/develop/headers/os/opengl")); + ad

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-05 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:85-86 + "/boot/system/develop/headers/os/net")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, + "/boot/system/develop/headers/os/opengl")); + addSystem

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-05 Thread Trung Nguyen via Phabricator via cfe-commits
trungnt2910 added a comment. I'm not the Haiku toolchain expert here 😅, all I can do is comparing this with what the GCC toolchain for Haiku does. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/li

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555794. brad edited the summary of this revision. brad added a comment. Separate out the GCC path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clan

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555785. brad added a comment. Add some C++ header path tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/tes

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555783. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/test/Driver/haiku.c cla

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555689. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp Index: clang/lib/Driver/ToolChains/Haiku.cpp ==

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added reviewers: nielx, korli, kallisti5. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Some fixes for the header / library paths.. - Use concat macro for all paths - Correct t