[PATCH] D159486: Fix build error in CI.

uabelho added a comment. Hi @zahiraam , I have a couple of downstream testcases that fail with this patch. Before > clang bbi-86364.c -lm -O3 > ./a.out passed but with the patch the assert in the program fails: a.out: bbi-86364.c:9: int main(): Assertion `(*__errno_location ()) == 33' f

[PATCH] D159486: Fix build error in CI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ff8f815c21: Fix buildbot failure (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642317 , @smeenai wrote: > I don't think pre-merge testing covers Mac, only Linux and Windows (which is > presumably how the original breakage got in). If the test passes for you > locally I'd just push it and monit

[PATCH] D159486: Fix build error in CI.

smeenai added a comment. I don't think pre-merge testing covers Mac, only Linux and Windows (which is presumably how the original breakage got in). If the test passes for you locally I'd just push it and monitor the bots afterwards. (That isn't general advice, but in this specific case, since w

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642309 , @smeenai wrote: > The `-triple x86_64-unknown-unknown` shouldn't be required after the regex > change, but I'm fine either way. I'd recommend pushing this to fix the bots, > and Aaron/Nico can do a post-com

[PATCH] D159486: Fix build error in CI.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. The `-triple x86_64-unknown-unknown` shouldn't be required after the regex change, but I'm fine either way. I'd recommend pushing this to fix the bots, and Aaron/Nico can do a post-commit re

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642305 , @smeenai wrote: > Generally it's preferred to either push bot failure fixes directly or revert > the original commit (also without review), to get bots unblocked as soon as > possible :) > > From what I can

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556301. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c ===

[PATCH] D159486: Fix build error in CI.

smeenai added a comment. Generally it's preferred to either push bot failure fixes directly or revert the original commit (also without review), to get bots unblocked as soon as possible :) From what I can see, the test failure is because `dso_local` isn't emitted on Mac. That seems incidental

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556297. zahiraam added a reviewer: thakis. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c =

[PATCH] D159486: Fix build error in CI.

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Fix buildbot failure https://lab.llvm.org/buildbot/#/builders/38/builds/14427. Repository: rG LLVM Github Monorepo