Re: [PATCH] D15967: Turn off lldb debug tuning by default for FreeBSD

2016-01-07 Thread Ed Maste via cfe-commits
emaste added a comment. > Sure, I was just making it the same as LLVM's default. Yeah, the defaults ought to be the same; it turns out this change was just premature. http://reviews.llvm.org/D15967 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D15967: Turn off lldb debug tuning by default for FreeBSD

2016-01-07 Thread Paul Robinson via cfe-commits
probinson added a comment. Sure, I was just making it the same as LLVM's default. Now that it's wired up through clang, people who want LLDB can use -glldb to get the same effect. http://reviews.llvm.org/D15967 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D15967: Turn off lldb debug tuning by default for FreeBSD

2016-01-07 Thread Ed Maste via cfe-commits
emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. I advocated for the lldb tuning by default on FreeBSD originally, but I didn't fully understand the implications. It turns out we're just not ready yet. So, LGTM. http://reviews.llvm.org/D15

[PATCH] D15967: Turn off lldb debug tuning by default for FreeBSD

2016-01-07 Thread Dimitry Andric via cfe-commits
dim created this revision. dim added reviewers: emaste, probinson. dim added a subscriber: cfe-commits. Herald added a subscriber: emaste. This is the clang part of D15966. In rL256104, debugger tuning was added to the clang driver, and again the default for FreeBSD was set to lldb. The default