pxli168 updated this revision to Diff 47074.
pxli168 updated the summary for this revision.
pxli168 added a comment.
Rebase for partition
http://reviews.llvm.org/D16047
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaInit.cpp
pxli168 marked 6 inline comments as done.
pxli168 added a comment.
I will separate this patch into small ones.
Comment at: lib/Sema/SemaDecl.cpp:5724
@@ +5723,3 @@
+ R->isPipeType()) {
+Diag(D.getIdentifierLoc(),
+
Anastasia added a comment.
Xiuli, do you still plan to continue here?
I was just thinking if it would make sense to re-upload the review since the
line numbers got broken due to full diff.
Also it would be nice to partition to several independent commits/reviews.
Let's say:
- Blocks
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7255
@@ -7209,3 +7254,3 @@
return PtrPtrKernelParam;
-return PointeeType.getAddressSpace() == 0 ? PrivatePtrKernelParam
- : PtrKernelParam;
+// Now
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:593
@@ -592,2 +592,3 @@
+def err_no_declarators : Error<"declaration does not declare anything">;
def ext_typedef_without_a_name : ExtWarn<"typedef requires a name">,
InGroup;
Anastasia added a comment.
Also generally it's much nicer to have small logically isolated changes
committed. I can see how you could partition this change into into pipe, blocks
and images.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:593
@@ -592,2 +592,3 @@
pxli168 created this revision.
pxli168 added reviewers: Anastasia, pekka.jaaskelainen.
pxli168 added subscribers: bader, cfe-commits.
Add Sema checks for opencl 2.0 new features: Block, pipe, atomic etc. Also fix
some old Sema check like pointer to image.
This patch is based on bader's patch in
pxli168 added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5733
@@ +5732,3 @@
+
+#if 0
+
pekka.jaaskelainen wrote:
> Is this intentionally included in the patch?
My mistake, just want to check if this works. But find it is handled by
something else.
pxli168 updated this revision to Diff 44599.
pxli168 added a comment.
Remove some unused codes and add inline comment.
http://reviews.llvm.org/D16047
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaInit.cpp
