Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

2016-01-28 Thread Nathan Wilson via cfe-commits
This revision was automatically updated to reflect the committed changes. nwilson marked an inline comment as done. Closed by commit rL259159: [Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p5 and p6: (authored by nwilson). Changed prior to commit:

Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

2016-01-21 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

2016-01-20 Thread Nathan Wilson via cfe-commits
nwilson updated this revision to Diff 45453. nwilson added a comment. - Take qualifiers into account. - Check `VarDecl` is valid when checking declaration type to account for `constexpr` being specified. Is there any opinion on a better way to handle this? I *could* check for both diagnostics

Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

2016-01-20 Thread Nathan Wilson via cfe-commits
nwilson marked an inline comment as done. Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p5.cpp:22 @@ +21,3 @@ +template +concept float fcrtf() { return 5.5; } // expected-error {{declared return type of function concept must be 'bool'}} +

Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

2016-01-13 Thread Nathan Wilson via cfe-commits
nwilson added a comment. Please let me know if the subject or summary of this Patch is ambiguous. http://reviews.llvm.org/D16163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits