Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Obsoleted by http://reviews.llvm.org/D16953. Repository: rL LLVM http://reviews.llvm.org/D16786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

LegalizeAdulthood added a comment. I am already working on fixing this bug (isn't PR25894 already assigned to me?), but what's missing from this patch is an automated test that proves it works. In order to write such an automated test, I believe

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16786#342074, @aaron.ballman wrote: > In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > > > I think proper solution will be to create tests for included files ot the > > fly, bu renaming main test to .h and creating

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I think proper solution will be to create tests for included files ot the fly, bu renaming main test to .h and creating dummy source file. But this is task for scripts wizards :-) Repository: rL LLVM http://reviews.llvm.org/D16786

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

aaron.ballman added a comment. In http://reviews.llvm.org/D16786#341938, @Eugene.Zelenko wrote: > I didn't notice test cases for included files for other checkers. So it's > hard to tell for should special test case introduced for this specific > problem or not. Generally speaking, all

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

aaron.ballman added a comment. In http://reviews.llvm.org/D16786#342075, @Eugene.Zelenko wrote: > In http://reviews.llvm.org/D16786#342074, @aaron.ballman wrote: > > > In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > > > > > I think proper solution will be to create tests for

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I didn't notice test cases for included files for other checkers. So it's hard to tell for should special test case introduced for this specific problem or not. Repository: rL LLVM http://reviews.llvm.org/D16786

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

aaron.ballman added a comment. In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > I think proper solution will be to create tests for included files ot the > fly, bu renaming main test to .h and creating dummy source file. But this is > task for scripts wizards :-) I'm not

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

aaron.ballman added a comment. Missing testcases for this; I suspect that isExpansionInMainFile was being used to filter out results in macro expansions, so some tests to ensure the behavior is correct there would also be appreciated. Repository: rL LLVM http://reviews.llvm.org/D16786

[PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This fix for PR25894. I checked it on my work code base. Build and