Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

2016-02-03 Thread Igor Sugak via cfe-commits
sugak added a comment. @rsmith: yes, I need someone to commit this. http://reviews.llvm.org/D16819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

2016-02-02 Thread Igor Sugak via cfe-commits
sugak created this revision. sugak added reviewers: rsmith, rjmccall. sugak added subscribers: hans, cfe-commits. gcc-4.8.1 fails to build clang because of a regression in that version of gcc (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58022). See details about the generated error in

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

2016-02-02 Thread John McCall via cfe-commits
rjmccall added a comment. LGTM, too. http://reviews.llvm.org/D16819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

2016-02-02 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yuck. Yeah, LGTM. Do you need someone to commit this for you? Hans, this should go into 3.8 as well. http://reviews.llvm.org/D16819 ___

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

2016-02-02 Thread Richard Smith via cfe-commits
rsmith closed this revision. rsmith added a comment. Thanks, committed as r259598. http://reviews.llvm.org/D16819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits