Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-24 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261767: Add whole-program vtable optimization feature to Clang. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D16821?vs=46697=48968#toc Repository: rL LLVM

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Peter Collingbourne via cfe-commits
On Mon, Feb 22, 2016 at 03:59:01PM -0800, Mehdi Amini wrote: > > > On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote: > > > > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: > >> > >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote:

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Mehdi Amini via cfe-commits
> On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote: > > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: >> >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: >>> >>> One thing that I'd like to do (and this would help CFI as well)

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Peter Collingbourne via cfe-commits
On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: > > > On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: > > > > One thing that I'd like to do (and this would help CFI as well) is to > > specifically recognize cases like this: > > > > ``` > > struct B { > >

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Pete Cooper via cfe-commits
> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: > > One thing that I'd like to do (and this would help CFI as well) is to > specifically recognize cases like this: > > ``` > struct B { > virtual void vf(); > }; > > struct D1 { > }; I assume you meant D1 : B here?

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:904-919 @@ -900,5 +903,18 @@ + +bool CodeGenModule::IsBitSetBlacklistedRecord(const CXXRecordDecl *RD) { + std::string TypeName = RD->getQualifiedNameAsString(); + auto isInBlacklist = [&](const SanitizerBlacklist

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-19 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:904-919 @@ -900,5 +903,18 @@ + +bool CodeGenModule::IsBitSetBlacklistedRecord(const CXXRecordDecl *RD) { + std::string TypeName = RD->getQualifiedNameAsString(); + auto isInBlacklist = [&](const

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-17 Thread Peter Collingbourne via cfe-commits
pcc added a reviewer: rsmith. pcc added a comment. Hi Richard, can you take a look please? http://reviews.llvm.org/D16821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-05 Thread Pete Cooper via cfe-commits
pete added a comment. Sorry I haven't got to this sooner. I'll try review what I can over the next day or two. Saying that, i'm not experienced enough in the clang codebase to give a LGTM. I can comment on style, but someone else will need to give the final ok.

[PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-02 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: joker.eph, pete, chandlerc. pcc added subscribers: hans, kcc, cfe-commits. This patch introduces the -fwhole-program-vtables flag, which enables the whole-program vtable optimization feature (D16795) in Clang. http://reviews.llvm.org/D16821 Files: