Re: [PATCH] D16973: Fix ICE with constexpr and friend functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL260675: Fix ICE with constexpr and friend functions (authored by ogoffart). Changed prior to commit: http://reviews.llvm.org/D16973?vs=47146=47791#toc Repository: rL LLVM

Re: [PATCH] D16973: Fix ICE with constexpr and friend functions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D16973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16973: Fix ICE with constexpr and friend functions

ogoffart added a comment. ping? http://reviews.llvm.org/D16973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16973: Fix ICE with constexpr and friend functions

ogoffart updated this revision to Diff 47146. ogoffart added a comment. Optimized by avoiding repeated call to getBody http://reviews.llvm.org/D16973 Files: lib/AST/ExprConstant.cpp test/SemaCXX/constant-expression-cxx11.cpp Index: test/SemaCXX/constant-expression-cxx11.cpp

[PATCH] D16973: Fix ICE with constexpr and friend functions

ogoffart created this revision. ogoffart added reviewers: rsmith, cfe-commits. Fix a crash while parsing this code: struct X { friend constexpr int foo(X*) { return 12; } static constexpr int j = foo(static_cast(nullptr)); }; I also added a test for the