RE: [PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

2016-02-10 Thread Romanova, Katya via cfe-commits
Subject: Re: [PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h) It's best not to commit things without approval once they've been sent for review (the assumption being that if you asked for review it's because the change needed review - time doesn't change

[PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

2016-02-09 Thread Katya Romanova via cfe-commits
kromanova created this revision. kromanova added reviewers: ygao, probinson, echristo, gribozavr, craig.topper, jroelofs. kromanova added a subscriber: cfe-commits. kromanova set the repository for this revision to rL LLVM. Eric Christopher told me that from now on it's OK to commit doxygen

Re: [PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

2016-02-09 Thread Katya Romanova via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260333: This patch adds doxygen comments for all the intrinsincs in the header fileā€¦ (authored by kromanova). Changed prior to commit: http://reviews.llvm.org/D17021?vs=47299=47394#toc Repository:

Re: [PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

2016-02-09 Thread David Blaikie via cfe-commits
It's best not to commit things without approval once they've been sent for review (the assumption being that if you asked for review it's because the change needed review - time doesn't change that fact) - if approval was given off-list (eg: on IRC) it's best to mention who gave it & where (&