[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

mehdi_amini closed this revision. mehdi_amini added a comment. Was committed a while back in r297798 https://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

mehdi_amini updated this revision to Diff 91804. mehdi_amini added a comment. Update: we set deployment by default even when not testing the system library. It is intentional because a REQUIRE in a test might be because an issue with libc for example. So for now the default is the OS on which

[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

mehdi_amini added inline comments. Comment at: test/libcxx/test/config.py:66 self.env = {} self.use_target = False self.use_system_cxx_lib = False mehdi_amini wrote: > EricWF wrote: > > Was the omission of `self.use_deployment` here

[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

mehdi_amini added inline comments. Comment at: test/libcxx/test/config.py:66 self.env = {} self.use_target = False self.use_system_cxx_lib = False EricWF wrote: > Was the omission of `self.use_deployment` here intentional? Python

[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

mehdi_amini updated this revision to Diff 90779. mehdi_amini added a comment. Add back the python changes (files were moved, I lost them in the rebase) https://reviews.llvm.org/D17469 Files: test/std/localization/locale.categories/category.ctype/ctype_base.pass.cpp

[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

mehdi_amini updated this revision to Diff 90773. mehdi_amini edited the summary of this revision. mehdi_amini added a comment. Rebase https://reviews.llvm.org/D17469 Files: test/std/localization/locale.categories/category.ctype/ctype_base.pass.cpp

[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

dexonsmith added a subscriber: mehdi_amini. dexonsmith added a comment. Mehdi, are you interested in rebasing this? https://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Eugene.Zelenko added a comment. It's fine. I just walk through all accepted revisions to find forgotten ones. https://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Correct. I haven't had a chance to get back to this. I'm aiming to pick it up again in the next week or two, but if this is specifically blocking you, feel free to rebase and commit on my behalf. > On 2016-Sep-26, at 13:39, Eugene Zelenko wrote: > > Eugene.Zelenko

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/libcxx/test/config.py:66 @@ -65,3 +65,3 @@ self.env = {} self.use_target = False self.use_system_cxx_lib = False

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

mclow.lists added a comment. This direction looks fine to me. All the test changes look fine to me. http://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. Does anyone have a problem with this direction? I have commits to follow that get tests green when run against various releases of OSX but I need this in place first. http://reviews.llvm.org/D17469

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Does anyone have a problem with this direction? I have commits to follow that get tests green when run against various releases of OSX but I need this in place first. > On 2016-Feb-19, at 17:59, Duncan P. N. Exon Smith via cfe-commits > wrote: > > dexonsmith

[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

dexonsmith created this revision. dexonsmith added reviewers: EricWF, mclow.lists. dexonsmith added a subscriber: cfe-commits. The tests for libc++ specify `-target` on the command-line to the compiler, but this is problematic for a few reasons. Firstly, the `-target` option isn't supported on