Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264241: [OpenCL] Add ocl and spir version for spir target (authored by pxl). Changed prior to commit: http://reviews.llvm.org/D17596?vs=51253&id=51509#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-22 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. LGTM! http://reviews.llvm.org/D17596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-21 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 51253. pxli168 added a comment. Add test for spir64. http://reviews.llvm.org/D17596 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl =

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-21 Thread Pekka Jääskeläinen via cfe-commits
pekka.jaaskelainen added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:15 @@ +14,2 @@ +// CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]} +// CL20: [[SPIR]] = !{i32 2, i32 0} Can you test 'spir64' too? http://reviews.llvm.org/D17596

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-20 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 51126. http://reviews.llvm.org/D17596 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl === --- /dev/null +++ test/CodeGenOpenCL/

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-20 Thread Xiuli PAN via cfe-commits
pxli168 marked 2 inline comments as done. pxli168 added a comment. http://reviews.llvm.org/D17596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-20 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:15 @@ +14,2 @@ +// CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]} +// CL20: [[SPIR]] = !{i32 2, i32 0} Anastasia wrote: > Forgotten to check OpenCL version here? The metadate will be me

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-02-26 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7211 @@ +7210,3 @@ + +/// SPIR uses emitTargetMD to emit spir spec requried metadate. +void SPIRTargetCodeGenInfo::emitTargetMD(const Decl *D, llvm::GlobalValue *GV, Could you change the comme

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-02-25 Thread Xiuli PAN via cfe-commits
pxli168 marked an inline comment as done. pxli168 added a comment. I think this is just a small change to help identify the which standard llvm-ir is using. And there is a SPIRV branch from Khronos https://github.com/KhronosGroup/SPIRV-LLVM We can start there and try to merge the spir-v support

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-02-25 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 49136. http://reviews.llvm.org/D17596 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl === --- /dev/null +++ test/CodeGenOpenCL/

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-02-25 Thread Yaxun Liu via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. Pls revise by Anastasia's comments. Otherwise LGTM. We have two options about SPIR-V support: 1. drop SPIR support and move on to SPIR-V 2. keep supporting both SPIR and SPIR-V Option 1 is cl

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-02-25 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. I was just wondering with SPIRV coming these days, how long should we be supporting and maintaining previous SPIR versions. Might be worth clarifying that... Comment at: lib/CodeGen/TargetInfo.cpp:7022 @@ -7021,1 +7021,3 @@ +class SPIRTargetCodeGen