Re: [PATCH] D17682: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE

2016-03-05 Thread Simon Pilgrim via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL262772: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE (authored by RKSimon). Changed prior to commit: http://reviews.llvm.org/D17682?vs=49552=49877#toc Repository: rL LLVM

Re: [PATCH] D17682: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE

2016-03-04 Thread Craig Topper via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D17682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17682: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE

2016-03-01 Thread Simon Pilgrim via cfe-commits
RKSimon updated this revision to Diff 49552. RKSimon added a comment. Thanks - I've removed adding XSAVE to btver2, as long as nobody thinks we need to keep it to be explicit? Repository: rL LLVM http://reviews.llvm.org/D17682 Files: lib/Basic/Targets.cpp

Re: [PATCH] D17682: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE

2016-03-01 Thread Yunzhong Gao via cfe-commits
ygao added a subscriber: ygao. Comment at: lib/Basic/Targets.cpp:2772 @@ -2771,2 +2771,3 @@ setFeatureEnabledImpl(Features, "xsaveopt", true); +setFeatureEnabledImpl(Features, "xsave", true); // FALLTHROUGH Is this line necessary? Line#3027 below in

[PATCH] D17682: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE

2016-02-27 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, andreadb. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. btver1 is a SSSE3/SSE4a only CPU - it doesn't have AVX and doesn't support XSAVE. This looks like some kind