Re: [PATCH] D17722: Make sure SLocEntry is an expansion before using getExpansion() method in SourceManager.

2016-03-02 Thread Haojian Wu via cfe-commits
hokein abandoned this revision. hokein added a comment. In http://reviews.llvm.org/D17722#365267, @bkramer wrote: > This doesn't have a test case. Also I don't understand why this is the > correct fix. If someone is calling one of those method with a file > SourceLocation (as opposed to a

Re: [PATCH] D17722: Make sure SLocEntry is an expansion before using getExpansion() method in SourceManager.

2016-03-01 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. This doesn't have a test case. Also I don't understand why this is the correct fix. If someone is calling one of those method with a file SourceLocation (as opposed to a macro SourceLocation) they should stop doing that. Repository: rL LLVM